Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NITRO env vars for NITRO_HOST and NITRO_HOST #388

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Use NITRO env vars for NITRO_HOST and NITRO_HOST #388

merged 1 commit into from
Nov 29, 2023

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Nov 29, 2023 •
edited
Loading

Use NITRO env vars for NITRO_HOST and NITRO_HOST and remove env var INDEX_GUI_PORT. Now you can use NITRO_PORT.

We were using INDEX_GUI_PORT to expose the container port but we were not changing the default NITRO port.

See: https://nitro.unjs.io/deploy/runtimes/node#environment-variables

Since we have to use NITRO_HOST we do not need anymore the INDEX_GUI_PORT var.

@josecelano
feat!: [torrust#381] add NITRO env vars for HOST and PORT
c39b5bd 
and remove env var `INDEX_GUI_PORT`. Now you can use `NITRO_PORT`.
@josecelano josecelano linked an issue Nov 29, 2023 that may be closed by this pull request
Allow to overwrite host and port in docker container #381
Closed
@josecelano josecelano requested a review from da2ce7 November 29, 2023 09:40
@josecelano josecelano added Documentation Improves Instructions, Guides, and Notices Code Cleanup / Refactoring Tidying and Making Neat - Admin - Enjoyable to Install and Setup our Software - Developer - Torrust Improvement Experience labels Nov 29, 2023
@josecelano
Copy link
Member Author

ACK c39b5bd

@josecelano josecelano merged commit 1be956f into torrust:develop Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees
No one assigned
Labels
- Admin - Enjoyable to Install and Setup our Software - Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat Documentation Improves Instructions, Guides, and Notices
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to overwrite host and port in docker container
1 participant
@josecelano