Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test for deleting tags #298

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

mario-nt
Copy link
Contributor

Resolves #229.

josecelano
josecelano previously approved these changes Oct 16, 2023
});

after(() => {
cy.delete_user_from_database(registration_form.username);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mario-nt, If the test fails, we could not have deleted the tag. Maybe we should try to delete it if it exists. If we want to keep the database clean after the test execution.

@mario-nt mario-nt force-pushed the #229-E2E-tests-delete-a-tag branch from fafd5a9 to 2a94d07 Compare October 25, 2023 17:51
@josecelano josecelano added the Needs Rebase Base Branch has Incompatibilities label Oct 27, 2023
@mario-nt mario-nt force-pushed the #229-E2E-tests-delete-a-tag branch from 2a94d07 to b81b3ea Compare November 9, 2023 17:05
@cgbosse cgbosse assigned cgbosse and mario-nt and unassigned cgbosse Jan 11, 2024
@cgbosse cgbosse added this to the v3.0.0 milestone Jan 12, 2024
@mario-nt mario-nt force-pushed the #229-E2E-tests-delete-a-tag branch 2 times, most recently from 700619f to 8081cd9 Compare February 26, 2024 17:38
@mario-nt mario-nt force-pushed the #229-E2E-tests-delete-a-tag branch from 7a99205 to 970dd60 Compare February 28, 2024 14:44
@mario-nt mario-nt force-pushed the #229-E2E-tests-delete-a-tag branch from 970dd60 to b50a981 Compare February 28, 2024 14:54
@josecelano
Copy link
Member

ACK b50a981

@josecelano josecelano merged commit b31d838 into torrust:develop Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Rebase Base Branch has Incompatibilities
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

E2E test: delete a tag
3 participants