Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: pass torrent.description from TorrentList to TorrentListTorrentDetails #533

Closed
hungfnt opened this issue Apr 22, 2024 · 3 comments · Fixed by #534
Closed

Suggestion: pass torrent.description from TorrentList to TorrentListTorrentDetails #533

hungfnt opened this issue Apr 22, 2024 · 3 comments · Fixed by #534
Labels
Optimization Make it Faster
Milestone
v3.0.0

Comments

@hungfnt
Copy link
Contributor

hungfnt commented Apr 22, 2024

The TorrentListTorrentDetails component only displays the torrent.description. Therefore, I think it's redundant to pass the torrent.info_hash and call the API each time a list item is clicked.
@josecelano
Copy link
Member

Hi @ngthhu good catch! That would be a good improvement. We can just pass the description from the parent component TorrentList and remove the extra API call.

Maybe, in the beginning, the intention was to show more info.

@josecelano josecelano added the Optimization Make it Faster label Apr 22, 2024
@josecelano josecelano added this to the v3.0.0 milestone Apr 22, 2024
@hungfnt
Copy link
Contributor Author

hungfnt commented Apr 22, 2024

There is one more thing: when the description includes links to images, it takes some time to load. Should we consider pre-rendering?

@josecelano
Copy link
Member

There is one more thing: when the description includes links to images, it takes some time to load. Should we consider pre-rendering?

Hi @ngthhu The reason is we are using a proxy for the images. There is an open issue to use a skeleton while the app is fetching the data.

hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
refactor:[torrust#533] pass description from TorrentList
c85be41
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
refactor:[torrust#533] pass description from TorrentList
8c0237c
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
refactor:[torrust#533] pass description from TorrentList
a492d5a
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
refactor:[torrust#533] pass description from TorrentList
14590b1
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
refactor:[torrust#533] pass description from TorrentList
fac4204
@josecelano josecelano linked a pull request Apr 22, 2024 that will close this issue
refactor:[#533] pass description from TorrentList #534
Merged
josecelano added a commit that referenced this issue Apr 27, 2024
@josecelano
Merge #534: refactor:[#533] pass description from TorrentList
5efc487 
fac4204 refactor:[#533] pass description from TorrentList (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK 356784a

Tree-SHA512: e3d6174bb95fec5df2b8fb57b1ff4342dde7f63308fb319a88c43b8fdef90ca629eaa64c74628141b30b6117551a597c81885af8c7a88513708bb503a4b61643
This was referenced Jun 12, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Optimization Make it Faster
Projects
Torrust Solution
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

refactor:[#533] pass description from TorrentList hungfnt/torrust-index-gui
2 participants
@josecelano @hungfnt