Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent font style in torrent details page #448

Closed
mario-nt opened this issue Jan 21, 2024 · 3 comments · Fixed by #536 or #560
Closed

Inconsistent font style in torrent details page #448

mario-nt opened this issue Jan 21, 2024 · 3 comments · Fixed by #536 or #560
Assignees
@hungfnt
Labels
- User - Enjoyable to Use our Software Easy Good for Newcomers Enhancement / Feature Request Something New Trivial Something Easy UI User Interface UX User Experience
Milestone
v3.0.0

Comments

@mario-nt
Copy link
Contributor

Some of the torrent fields in the torrent detail page has an inconsistent style:

image

Creation date for example, has a brighter color, almost with a bold style, while others, like created by, has a darker font color.
@mario-nt mario-nt added Easy Good for Newcomers - User - Enjoyable to Use our Software Trivial Something Easy labels Jan 21, 2024
@josecelano josecelano added this to the v3.0.0 milestone Jan 22, 2024
@josecelano josecelano added UX User Experience UI User Interface labels Jan 26, 2024
@mario-nt mario-nt removed their assignment Jan 30, 2024
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 23, 2024
@hungfnt
fix:[torrust#448] use Markdown for CreationDateTab
a9baa2c
@josecelano josecelano linked a pull request Apr 23, 2024 that will close this issue
fix:[#448] use Markdown for CreationDateTab #536
Merged
josecelano added a commit that referenced this issue Apr 23, 2024
@josecelano
Merge #536: fix:[#448] use Markdown for CreationDateTab
444470a 
a9baa2c fix:[#448] use Markdown for CreationDateTab (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK a9baa2c

Tree-SHA512: 49e556af9e86a97c7f26c061081d8ab51d0f5c2e5763f85bb5be339e0ce96c65ec040e968b801f0f752a55d71c5336ba5c8bb6652c601b3dfae8bfcf8fbf257e
@mario-nt mario-nt reopened this May 16, 2024
@mario-nt
Copy link
Contributor Author

Hi @ngthhu, I am reopening the issue because when there is no data, for example, when no comment is provided, the font color is still slightly brighter.

Feel free to fix it yourself if you want or someone in the team will do it.

@hungfnt
Copy link
Contributor

hungfnt commented May 16, 2024

Hi @mario-nt, I thought the 'No description' text was designed to be different, I'll fix it.

hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue May 17, 2024
@hungfnt
fix:[torrust#448] no data font color fix
e4c5018
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue May 17, 2024
@hungfnt
fix:[torrust#448] no data font color fix
a0d6cfa
@josecelano josecelano linked a pull request May 17, 2024 that will close this issue
fix:[#448] no data font color fix #560
Merged
@mario-nt
Copy link
Contributor Author

Hi @mario-nt, I thought the 'No description' text was designed to be different, I'll fix it.

Hi, yup, I would keep the italic, but use the same font color as the fields with info, if you have any suggestions feel free to speak up.

josecelano added a commit that referenced this issue May 20, 2024
@josecelano
Merge #560: fix:[#448] no data font color fix
9b105ef 
a0d6cfa fix:[#448] no data font color fix (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK a0d6cfa

Tree-SHA512: 833f2ec0a3fcdf32aec35b17c34e4627d8c1032c84d8ba49222da06050c0fdce4387e8ed3d9d1b853559bf3edba6fc219c43d2d4fd15fd82f8d7ac7cf7ff96dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hungfnt hungfnt

Labels
- User - Enjoyable to Use our Software Easy Good for Newcomers Enhancement / Feature Request Something New Trivial Something Easy UI User Interface UX User Experience
Projects
Torrust Solution
Status: Done
Milestone
v3.0.0
3 participants
@josecelano @mario-nt @hungfnt