feat: cors support for all requests #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javascript browser clients can now use hastebin. Fix toptal#352 Fix toptal#47
Closed
|
Hi @IJustDev I'm not sure we should have this enabled by default since, as it was already pointed out in one of the issues you linked, it could result in one extra point of concern for malicious usage. Users that already have haste-server installed could be surprised by their servers suddenly accepting cross-origin requests. WDYT about having that conditionally enabled by an ENV var? Disabled by default. It wouldn't add much extra volume to your PR while keeping backwards compatibility. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript browser clients can now use hastebin.
Fix #352 Fix #47