Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of custom path in yarn-install #364

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

denieler
Copy link
Contributor

@denieler denieler commented Dec 9, 2024

Description

Fix for custom usage of path parameter. If path input parameter is used - use yarn.lock file from that path to generate cache hash.

The modified GHA is tested in https://github.com/toptal/client-portal/actions/runs/12235817455 (https://github.com/toptal/client-portal/pull/10141)

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping teams for review

@denieler denieler self-assigned this Dec 9, 2024
@denieler denieler requested a review from a team as a code owner December 9, 2024 12:33
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 6d1f6b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@denieler
Copy link
Contributor Author

denieler commented Dec 9, 2024

@toptal-anvil ping reviewers

@sashuk sashuk requested a review from a team December 9, 2024 13:37
@denieler denieler merged commit 524ad91 into master Dec 9, 2024
4 of 5 checks passed
@denieler denieler deleted the bill-fix-usage-of-custom-path-in-install branch December 9, 2024 14:09
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants