Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4724] Add action for updating dependencies to the latest #259

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

augustobmoura
Copy link
Contributor

@augustobmoura augustobmoura commented Jan 9, 2024

FX-4724

Description

Add action for updating a NPM dependency to the latest version possible. Useful for Picasso and Davinci updates

How to test

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@augustobmoura augustobmoura requested review from a team, sashuk, dmaklygin, TomasSlama and mkrl January 9, 2024 16:38
Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: f59ad0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@augustobmoura augustobmoura force-pushed the fx-4724-batch-dependency-updater branch 2 times, most recently from 780983d to f4d5c1a Compare January 9, 2024 20:39
@augustobmoura augustobmoura changed the title Add updated dependency package Add action for updating dependencies to the latest Jan 10, 2024
@augustobmoura augustobmoura changed the title Add action for updating dependencies to the latest [FX-4724] Add action for updating dependencies to the latest Jan 10, 2024
@augustobmoura augustobmoura force-pushed the fx-4724-batch-dependency-updater branch from aa52ef0 to f59ad0c Compare January 10, 2024 03:05
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

It would be cool, if we would be able to see from what version we are updating in the PR description, so it would be easier to notice breaking changes. Maybe major bumps could be even in bold.

Also adding link to picasso releases and davinci releases might be good experience for the user

Copy link
Collaborator

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! Agree with proposals in #259 (review)

I think this action should be definitely announced in #front-end channel, it will be very useful for other projects

@augustobmoura augustobmoura merged commit 7ef334d into master Jan 12, 2024
6 checks passed
@augustobmoura augustobmoura deleted the fx-4724-batch-dependency-updater branch January 12, 2024 00:29
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants