-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to retry yarn-install #251
Add option to retry yarn-install #251
Conversation
🦋 Changeset detectedLatest commit: 124f69d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8f2d02e
to
cb56d53
Compare
ad80294
to
124f69d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be the default 1? What about increasing it to 2 to fix this common issue for everyone? 🤔
I don't think it is as common on other projects, and enabling retries by default could impact on pricing, as projects that would otherwise fail, would re-run yarn install again and increase the action running time. It would also be a breaking change, so maybe we can avoid it by default now and enable it where problems are more common |
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
FX-4959
Description
Adds option to retry yarn install
How to test
Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers
- Ping FX team for review