Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to retry yarn-install #251

Conversation

augustobmoura
Copy link
Contributor

@augustobmoura augustobmoura commented Dec 19, 2023

FX-4959

Description

Adds option to retry yarn install

How to test

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 124f69d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@augustobmoura augustobmoura self-assigned this Dec 19, 2023
@augustobmoura augustobmoura force-pushed the fx-4549-add-retry-option-to-yarn-install-action-and-adopt-it-in-staff-portal-rc branch from 8f2d02e to cb56d53 Compare December 19, 2023 02:21
@augustobmoura augustobmoura force-pushed the fx-4549-add-retry-option-to-yarn-install-action-and-adopt-it-in-staff-portal-rc branch from ad80294 to 124f69d Compare December 19, 2023 02:55
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the default 1? What about increasing it to 2 to fix this common issue for everyone? 🤔

@augustobmoura
Copy link
Contributor Author

should be the default 1? What about increasing it to 2 to fix this common issue for everyone? 🤔

I don't think it is as common on other projects, and enabling retries by default could impact on pricing, as projects that would otherwise fail, would re-run yarn install again and increase the action running time. It would also be a breaking change, so maybe we can avoid it by default now and enable it where problems are more common

@augustobmoura
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@augustobmoura augustobmoura merged commit 3822c87 into master Dec 22, 2023
6 checks passed
@augustobmoura augustobmoura deleted the fx-4549-add-retry-option-to-yarn-install-action-and-adopt-it-in-staff-portal-rc branch December 22, 2023 13:00
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants