Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor operator checker #19

Merged
merged 16 commits into from
Dec 20, 2023
Merged

Conversation

topherinternational
Copy link
Owner

@topherinternational topherinternational commented Dec 20, 2023

A bunch of refactor items:

  • Break the OperatorChecker into more methods/functions
  • Each pylint rule we implement has a corresponding check_<rule>() method, isolating the logic of the check from how we procure the nodes needed to compute the check result
  • Test the check methods individually
  • Use a custom dataclass for extracting the task/operator parameters from an assignment node
  • Move the pylint MSGS to the top of each module for easier reading

@topherinternational topherinternational merged commit 0915c73 into main Dec 20, 2023
2 checks passed
@topherinternational topherinternational deleted the refactor-operator-checker branch December 20, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant