Improve OpenBSD -CURRENT detection and Dry-run feedback #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Oct 16, 2024
This commit improves the -CURRENT detection by way of parsing `/etc/motd`. This change is more future-proof as when OpenBSD nears a stable release, `uname` will temporarily report like -STABLE. This commit *also* adds feedback if -CURRENT is found to make debugging this feature easier with `--dry-run`, or, just a regular run as well.
|
Force pushed a fix to my fork. Thanks for the review. This good? |
SteveLauC
reviewed
Oct 16, 2024
This commit removes the command flag feedback. This commit also swaps the output "update", for "upgrade", making this step closer to other steps for consistency.
|
Pushed a commit to make it less talky. I also swapped "update" for "upgrade" to mirror other steps' verbiage. Ok? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This commit improves the -CURRENT detection by way of parsing
/etc/motd. This change is more future-proof as when OpenBSD nears a stable release,unamewill temporarily report like -STABLE.This commit also adds feedback if -CURRENT is found to make debugging this feature easier with
--dry-run, or, just a regular run as well.Standards checklist
CONTRIBUTING.md