Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghcup step #89

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Add ghcup step #89

merged 2 commits into from
Oct 30, 2022

Conversation

9999years
Copy link
Contributor

This upgrades ghcup: https://www.haskell.org/ghcup/

Potential work: if stack is installed through ghcup, you're not supposed to run stack upgrade, so I could potentially patch this to ignore the stack step when ghcup is present. (And/or detect if stack is a ghcup-installed stack.)

Standards checklist:

  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
    • Yes but it ran zero tests? Also I didn't write any
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #89 (604dd74) into master (9cd155f) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #89      +/-   ##
=========================================
- Coverage    3.50%   3.35%   -0.15%     
=========================================
  Files          27      27              
  Lines        3141    3280     +139     
=========================================
  Hits          110     110              
- Misses       3031    3170     +139     
Impacted Files Coverage Δ
src/config.rs 0.00% <0.00%> (ø)
src/main.rs 0.42% <0.00%> (-0.01%) ⬇️
src/steps/containers.rs 0.00% <0.00%> (ø)
src/steps/emacs.rs 0.00% <0.00%> (ø)
src/steps/generic.rs 0.00% <0.00%> (ø)
src/steps/git.rs 0.00% <0.00%> (ø)
src/steps/kakoune.rs 0.00% <0.00%> (ø)
src/steps/node.rs 0.00% <0.00%> (ø)
src/steps/os/archlinux.rs 0.00% <0.00%> (ø)
src/steps/os/linux.rs 22.29% <0.00%> (-1.01%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@s34m s34m merged commit 18cec5c into topgrade-rs:master Oct 30, 2022
@9999years 9999years deleted the ghcup branch October 30, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants