Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make GitSteps a dedicated step #737

Merged

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Mar 9, 2024

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


This PR makes GitRepos an individual step, and it will collect git repos every time when the step is involved, so it should fixs #728.

cc @float3

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 230 lines in your changes are missing coverage. Please review.

Project coverage is 5.43%. Comparing base (12116c3) to head (1c0127a).

Files Patch % Lines
src/steps/git.rs 0.00% 224 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️
src/steps/zsh.rs 0.00% 2 Missing ⚠️
src/execution_context.rs 0.00% 1 Missing ⚠️
src/steps/os/windows.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #737      +/-   ##
========================================
- Coverage   5.48%   5.43%   -0.06%     
========================================
  Files         37      37              
  Lines      11862   11988     +126     
========================================
  Hits         651     651              
- Misses     11211   11337     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLauC
Copy link
Member Author

Here is a build for linux-musl, welcome to give it a test: https://github.com/SteveLauC/topgrade/releases/tag/pr737

@SteveLauC SteveLauC linked an issue Mar 9, 2024 that may be closed by this pull request
@float3
Copy link

float3 commented Mar 9, 2024

nice! thank you

@SteveLauC SteveLauC merged commit 2c1ce3d into topgrade-rs:main Mar 9, 2024
17 of 19 checks passed
@SteveLauC SteveLauC deleted the fix/do_not_cache_git_additional_repos branch March 9, 2024 09:57
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expanded glob git repo directory cache needs to be invalidated I think
2 participants