fix(os) consider Fedora Kinoite to be the Fedora Silverblue distribution #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
6 tasks
SteveLauC
reviewed
Jan 7, 2024
src/steps/os/linux.rs
Outdated
| @@ -54,7 +54,7 @@ impl Distribution { | |||
| Some("clear-linux-os") => Distribution::ClearLinux, | |||
| Some("fedora") | Some("nobara") => { | |||
| return if let Some(variant) = variant { | |||
| if variant.contains(&"Silverblue") { | |||
| if variant.contains(&"Silverblue") || variant.contains(&"Kinoite") { | |||
| Ok(Distribution::FedoraSilverblue) | |||
There was a problem hiding this comment.
What about we rename Distribution::FedoraSilverblue to Distribution::FedoraImmutable since they
only differ in their desktop environments and all use ostree as their package manager
There was a problem hiding this comment.
If you want to add tests on parsing their /etc/os-release files, you can find them here: https://github.com/which-distro/os-release/tree/main/fedora
There was a problem hiding this comment.
I like it. I'll have another commit up soon.
Rename FedoraSilverblue Distribution to FedoraImmutable. Add test cases for Onyx, Sericea and Silverblue. Rename upgrade method to match distribution. Fixes topgrade-rs#637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
CONTRIBUTING.mdcargo build)cargo fmt)cargo clippy)cargo test)For new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.