Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bun packages step #599

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Conversation

LeSnake04
Copy link
Contributor

@LeSnake04 LeSnake04 commented Nov 3, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command (N/A: no confirmation dialog)

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Notes

Bun has a --dry-run command but it lists all installed packages so its output is probably too verbose to be useful for most users.

PS: I triple checked that I didn't forget the require call this time.

@SteveLauC
Copy link
Member

Thanks! :)

@SteveLauC SteveLauC merged commit 465df2e into topgrade-rs:main Nov 5, 2023
8 checks passed
@LeSnake04 LeSnake04 deleted the bun-install branch November 6, 2023 07:08
@JakobFels
Copy link
Contributor

This step fails if there are no packages installed globally (but bun is installed)

bun -g update
No package.json, so nothing to update

@JakobFels
Copy link
Contributor

The step should probably check if
~/.bun/install/global/package.json exists

@LeSnake04
Copy link
Contributor Author

fixed it #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants