fix: make logger work while loading config file #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
CONTRIBUTING.md
cargo build
)cargo fmt
)cargo clippy
)cargo test
)For new steps
--dry-run
option works with this step--yes
option works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.
What does this PR do
Make the logger work while loading the configuration file
A few days ago, I noticed that the configuration file was no longer printed in verbose mode, and found that our logger will ONLY be initialized after loading the config file, this behavior was introduced in Allow setting
misc.log_filters
inconfig.toml
#552, and this PR fixes it by setting our logger in 2 phases:Set up it with the log level (filter directives) specified in the CLI option
Update it with the log levels specified in the CLI option and the config file
For more details, see the code comments
Replace the default log level setting with a const variable
DEFAULT_LOG_LEVEL
Style change, import
tracing::<log_macro!>
when using it