Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprioritize please-sudo #541

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Aug 21, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: The --dry-run option works with this step
  • Optional: Topgrade skips this step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


What does this PR do

  1. Deprioritize the please sudo in Sudo::detect() as it is not that popular when compared to other sudo commands

Breaking Change

  1. For guys that are using please, if you have other sudo commands installed, this is a breaking change, you need to manually set the sudo command to please:

    [misc]
    sudo_command = "please"
    

Closes #539

@SteveLauC SteveLauC changed the title refactor: deprioritze please-sudo refactor: deprioritize please-sudo Aug 21, 2023
@SteveLauC SteveLauC merged commit 13a46a4 into topgrade-rs:master Aug 22, 2023
@SteveLauC SteveLauC deleted the please-sudo branch August 22, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update system when please-cli is installed
1 participant