New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading log message when detecting rbenv #249

Merged

s34m merged 1 commit into topgrade-rs:dev from rm3l:fix_misleading_log_when_detecting_rbenv

Dec 5, 2022

Contributor

rm3l commented Dec 5, 2022

Standards checklist:

The PR title is descriptive.
The code compiles (cargo build)
The code passes rustfmt (cargo fmt)
The code passes clippy (cargo clippy)
The code passes tests (cargo test)
Optional: I have tested the code myself
- I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

This is a follow-up to a review comment added in #248 (comment)

cc @mouse07410 @DottoDev


          Fix misleading log message after detecting rbenv

5343d40

This is a follow-up to a comment added in [1].

[1] topgrade-rs#248 (comment)

rm3l mentioned this pull request

Fix issue with RubyGems update command #248

Merged

7 tasks

s34m approved these changes

View reviewed changes

s34m merged commit 1dee462 into topgrade-rs:dev

rm3l deleted the fix_misleading_log_when_detecting_rbenv branch

December 5, 2022 17:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet