Improve help prompt value names #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent PR! Visual Changes:
|
pan93412
approved these changes
Nov 5, 2022
|
the custom-command logic could probably use some improvement, as it seems to always run all the items from custom commands instead of just the selected ones |
s34m
approved these changes
Nov 5, 2022
|
Could you change the branch to the bug-fixes branch. |
|
Done |
tranzystorekk
force-pushed
the
clap-value-names
branch
from
c60effb to
0713ebc
Compare
s34m
added a commit
that referenced
this pull request
Nov 6, 2022
* Closes #150 please disable distrobox by default (#151) * Check if distrobox exists before running step * Improve help prompt value names (#153) * 159 self update error message with standalone versions (#161) * Rename back to topgrade * Bugfix Version bump * Changes reference to topgrade-rs in self-update * Fixes distrobox errors (#160) * Rename back to topgrade * Bugfix Version bump * Check if distrobox exists before running step * Fixed sitrobox and version bump * Version bump to 10.1.2 Co-authored-by: Marcin Puc <tranzystorek.io@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
cargo build)cargo fmt)cargo clippy)cargo test)If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.