Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-201: removed automated smoke test Dockerfile and removed the option from circle ci #7033

Merged
merged 1 commit into from
Jan 15, 2025
Merged

PM-201: removed automated smoke test Dockerfile and removed the option from circle ci #7033

merged 1 commit into from
Jan 15, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Removed automated smoke test dockerfile as it is outdated(Asked Sathya about this and got a reply that it is not used now)
  • Also, removed the option from circle ci

@hentrymartin hentrymartin marked this pull request as ready for review January 14, 2025 16:17
kkartunov
kkartunov approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hentrymartin hentrymartin merged commit 4c56238 into develop Jan 15, 2025
4 checks passed
@hentrymartin hentrymartin deleted the pm-201 branch January 15, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkartunov kkartunov kkartunov approved these changes

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@luizrrodrigues luizrrodrigues Awaiting requested review from luizrrodrigues luizrrodrigues is a code owner

@jmgasper jmgasper Awaiting requested review from jmgasper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hentrymartin @kkartunov