Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PM-195): Cross site request forgery #7031

Merged
merged 6 commits into from
Jan 13, 2025
Merged

fix(PM-195): Cross site request forgery #7031

merged 6 commits into from
Jan 13, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Removed some of the api's which are not being used anymore
  • This will remove the cross site request forgery vulnerabilities in them

@hentrymartin hentrymartin marked this pull request as ready for review January 8, 2025 20:51
@hentrymartin hentrymartin requested review from jmgasper and kkartunov and removed request for ajefts and luizrrodrigues January 8, 2025 20:51
jmgasper
jmgasper reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@jmgasper jmgasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just chatting with a Marathon Match copilot today who mentioned they are planning a year long MM with leaderboards. Will that still work with the mmLeaderboard service going away? I'm not quite sure if that service is still used or not...

@hentrymartin
Copy link
Collaborator Author

I was just chatting with a Marathon Match copilot today who mentioned they are planning a year long MM with leaderboards. Will that still work with the mmLeaderboard service going away? I'm not quite sure if that service is still used or not...

@jmgasper I've added back the mml service

@hentrymartin hentrymartin merged commit 4422235 into develop Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkartunov kkartunov kkartunov approved these changes

@jmgasper jmgasper jmgasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hentrymartin @jmgasper @kkartunov