Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @extends PHPDocs #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tychokamphuis-aqqo
Copy link

Thank you for all the great work on this project!
This PR updates the @extends PHPDocs to align with the latest PHPDoc standards in Laravel, ensuring improved consistency and compatibility.

Please let me know if there’s anything you'd like adjusted or further explained.

Thanks again!

@Justin-vdm
Copy link

Justin-vdm commented Nov 12, 2024

I’m encountering the same issues as well. Looking forward to seeing this improvement.

@SlyDave
Copy link

SlyDave commented Nov 12, 2024

Might also be worth updating Database/Eloquent/Concerns/HasRelationships

currently they return:

    /**
     * Define a one-to-one relationship.
     *
     * @param string            $related
     * @param string|array|null $foreignKey
     * @param string|array|null $localKey
     *
     * @return \Awobaz\Compoships\Database\Eloquent\Relations\HasOne
     */

When you'd expect something like:

    /**
     * Define a one-to-one relationship.
     *
     * @template TRelatedModel of \Illuminate\Database\Eloquent\Model
     *
     * @param  class-string<TRelatedModel>  $related
     * @param  string|array|null  $foreignKey
     * @param  string|array|null  $localKey
     * @return \Awobaz\Compoships\Database\Eloquent\Relations\HasOne<TRelatedModel, $this>
     */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants