Fix FetchAtomService content type handling #9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's required by the ActivityPub spec
mime_type strips the profile from the content type, but it's still available raw in the headers hash
valerauko
changed the title
Gargron
approved these changes
Oct 30, 2018
|
This broke remote resource resolving because the "raw" header contains stuff like I missed this bug during review and I am very regretful about it. I need to revert this patch. |
Gargron
added a commit
that referenced
this pull request
Oct 30, 2018
|
Sorry about the trouble caused. |
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Oct 31, 2018
…astodon#9171) This reverts commit c36a4a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #8773
Changes
headers['Content-type']instead ofmime_typeThe latter strips out the
profilepart of the content type header, so compliant ActivityPub services don't get handled properly.headers['Content-type']has the "raw" content type with the profile, so use that for checking.