Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notifications settings #12497

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Improve notifications settings #12497

merged 1 commit into from
Nov 29, 2019

Conversation

brawaru
Copy link
Contributor

@brawaru brawaru commented Nov 28, 2019

Motivation

Currently notifications page seems a bit cluttered with no clear separation between e-mail and filtering settings. This PR tries to address them by adding clear separation with headers, hints and removing continuously reused texts for events checkboxes.

Visual Comparison:

(click to see full sized pictures)

Before After
Screenshot of "cluttered" settings before these fixes Screenshot of settings after, highlighting new headings hints and changed checkboxes texts
Warning about visuals

Please note, that due to my technical inability to set up Mastodon instance to test these changes, screenshots above were made with browser's developer tools, using the texts from files and placing new elements at expected places. If that does not satisfy you, you may set up your own instance and review changes manually.

A word about PR

I'm nowhere familiar with what “HAML” is and not explored it yet, because this commit is so small, the changes primarily were made by reviewing other files in project and guessing the syntax. I expect maintainers (or reviewers) to test it and suggest what to fix and how. Thanks!

@@ -580,6 +580,10 @@ en:
discovery: Discovery
sensitive_content: Sensitive content
toot_layout: Toot layout
notifications:
email_events: Events for e-mail notifications
email_events_hint: Select events that you want to receive notifications for
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one clearly missing a termination! If you are reviewing this, please tell: should I use colon (:) here or just dot (.) is okay?

@brawaru
Copy link
Contributor Author

brawaru commented Nov 28, 2019

I also missed to normalize localization files, that's why CI failed. Fixed.

Previous question is still active though. Whenever it resolves, I will squash the commits (hope this is okay).

UPD: (stares at CI status) “What is wrong with you? >_>”

config/locales/bn.yml Outdated Show resolved Hide resolved
config/locales/eu.yml Outdated Show resolved Hide resolved
config/locales/gl.yml Outdated Show resolved Hide resolved
config/locales/hu.yml Outdated Show resolved Hide resolved
config/locales/hu.yml Outdated Show resolved Hide resolved
config/locales/id.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/nl.yml Outdated Show resolved Hide resolved
config/locales/sv.yml Outdated Show resolved Hide resolved
config/locales/uk.yml Outdated Show resolved Hide resolved
Currently notifications page seems a bit cluttered with no clear
separation between e-mail and filtering settings. This commit tries to
address them by adding clear separation with headers, hints and removing
continuously reused texts for events checkboxes.
@Gargron Gargron merged commit fd45f5b into mastodon:master Nov 29, 2019
@brawaru brawaru deleted the feat/improve-notif-settings branch April 2, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants