fix: prevent nested validations from throwing #674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the decorator
@ValidateNested({each: true])
fromclass-validator
like in the above example, theI18nService.validate(...)
method will throw the following errorTypeError: Cannot convert undefined or null to object
.This is because in the absence of validation errors in the parent, the
constraints
property of theValidationError
will beundefined
. Thus, the call toObject.keys(error.constraints)
in theformatI18nErrors
util function will fail. SinceObject.keys
only works with objects.Linked Issues
Fixes #633
Additional context