Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#646): I18nValidationExceptionFilter error response body #647

Merged

Conversation

Jeel-Parikh
Copy link
Contributor

Closes Issue no: #646

This PR addresses issue #646 by modifying the buildResponseBody method in the I18nValidationExceptionFilter class. The goal is to standardize the error response structure for validation errors, ensuring consistency across all exception types in NestJS.

@rubiin
Copy link
Collaborator

rubiin commented Sep 7, 2024

@Jeel-Parikh please fix the broken tests

@Jeel-Parikh
Copy link
Contributor Author

@rubiin I have fixed the broken tests

@coveralls
Copy link

coveralls commented Sep 8, 2024

Coverage Status

coverage: 90.901% (+0.02%) from 90.885%
when pulling dc8b725 on Jeel-Parikh:fix/exception_filter_error_res
into e9732dd on toonvanstrijp:main.

@rubiin rubiin merged commit b8e84f1 into toonvanstrijp:main Sep 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants