Add temp dir, cleanup codebase, ready for release 0.6.0 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.3.4 to 5.3.5. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@5.3.4...5.3.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump pytest from 5.3.4 to 5.3.5
…ibution magnitude. docs: add schedutron as a contributor docs: add AbdullahElagha as a contributor docs: add HCamberos as a contributor docs: add mbarakaja as a contributor docs: add destag as a contributor docs: add malexanderboyd as a contributor docs: add Ginkooo as a contributor docs: add toonarmycaptain as a contributor docs: create .all-contributorsrc [skip ci] docs: update README.md [skip ci]
Bumps [matplotlib](https://github.com/matplotlib/matplotlib) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.1.2...v3.1.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…b-3.1.3 Bump matplotlib from 3.1.2 to 3.1.3
Bumps [setuptools](https://github.com/pypa/setuptools) from 45.1.0 to 45.2.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v45.1.0...v45.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…s-45.2.0 Bump setuptools from 45.1.0 to 45.2.0
Bumps [coveralls](https://github.com/coveralls-clients/coveralls-python) from 1.10.0 to 1.11.1. - [Release notes](https://github.com/coveralls-clients/coveralls-python/releases) - [Changelog](https://github.com/coveralls-clients/coveralls-python/blob/master/CHANGELOG.md) - [Commits](TheKevJames/coveralls-python@1.10.0...1.11.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…-1.11.1 Bump coveralls from 1.10.0 to 1.11.1
Bumps [pytest-mypy](https://github.com/dbader/pytest-mypy) from 0.4.2 to 0.5.0. - [Release notes](https://github.com/dbader/pytest-mypy/releases) - [Changelog](https://github.com/dbader/pytest-mypy/blob/master/changelog.md) - [Commits](realpython/pytest-mypy@v0.4.2...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…py-0.5.0 Bump pytest-mypy from 0.4.2 to 0.5.0
…20-03-01 Scheduled monthly dependency update for March
Bumps [setuptools](https://github.com/pypa/setuptools) from 45.2.0 to 46.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v45.2.0...v46.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [pytest-mypy](https://github.com/dbader/pytest-mypy) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/dbader/pytest-mypy/releases) - [Changelog](https://github.com/dbader/pytest-mypy/blob/master/changelog.md) - [Commits](realpython/pytest-mypy@v0.5.0...v0.6.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [codecov](https://github.com/codecov/codecov-python) from 2.0.16 to 2.0.22. - [Release notes](https://github.com/codecov/codecov-python/releases) - [Changelog](https://github.com/codecov/codecov-python/blob/v2.0.22/CHANGELOG.md) - [Commits](codecov/codecov-python@v2.0.16...v2.0.22) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
….0.22 Bump codecov from 2.0.16 to 2.0.22
…py-0.6.0 Bump pytest-mypy from 0.5.0 to 0.6.0
Bumps [mypy](https://github.com/python/mypy) from 0.761 to 0.770. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.761...v0.770) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…s-46.0.0 Bump setuptools from 45.2.0 to 46.0.0
Bumps [matplotlib](https://github.com/matplotlib/matplotlib) from 3.1.3 to 3.2.1. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.1.3...v3.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump mypy from 0.761 to 0.770
Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.0.3 to 5.0.4. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@coverage-5.0.3...coverage-5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…b-3.2.1 Bump matplotlib from 3.1.3 to 3.2.1
…5.0.4 Bump coverage from 5.0.3 to 5.0.4
Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.3.5 to 5.4.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@5.3.5...5.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump pytest from 5.3.5 to 5.4.1
Bumps [setuptools](https://github.com/pypa/setuptools) from 46.0.0 to 46.1.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v46.0.0...v46.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…s-46.1.1 Bump setuptools from 46.0.0 to 46.1.1
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Initial use: to cache added avatars to be written database with class. initialise_app -> data_folder_check() will ensure dir exists at runtime. Add path to DataFolder. Add variable TEMP_DIR to settings_functions.py. Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
This subclass implements temp dir for class in app temp directory, with 'avatars' dir for holding user avatars before writing to database. Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Cache avatars in temp folder, then move to class_data/database when class is written. take_student_avatar now takes NewClass instead of a class name, copies avatars to NewClass.temp_avatars_dir using file_functions.copy_file. create_classlist_data copies cached avatars after writing class to file. Added functions: copy_avatars_to_class_data, copy_avatar_to_class_data Remove functions: copy_avatar_to_app_data Note this solves issue caused by creating folders etc after taking user input, as user adding avatar was trying to copy to new class folders that didn't exist yet due to previous change that separated logic from writing to disk/database, postponing folder creation until writing, where previously avatars were copied to created folder one by one as user supplied them for each added student. NB Above issue is a good candidate for end-to-testing if/when this is implemented. Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Bumps [setuptools](https://github.com/pypa/setuptools) from 46.1.1 to 46.1.3. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v46.1.1...v46.1.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…s-46.1.3 Bump setuptools from 46.1.1 to 46.1.3
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
This fixes bug where name with disallowed characters would be used as a directory name. Also added test ensuring path_safe_name is used. Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Change `new_chart`/`assemble_chart_data` to take `Class`/`NewClass` object instead of a class name. - Supports passing in class directly from `create_class` without reloading from database. - Move logic prompting user to choose a class from `assemble_chart_data` to `new_chart`. Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
|
👉 View analysis in DeepCode’s Dashboard |
Pull Request Test Coverage Report for Build 1187
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=========================================
+ Coverage 92.9% 94.3% +1.39%
=========================================
Files 22 22
Lines 916 948 +32
=========================================
+ Hits 851 894 +43
+ Misses 65 54 -11
Continue to review full report at Codecov.
|
Signed-off-by: toonarmycaptain <toonarmycaptain@hotmail.com>
toonarmycaptain
changed the title
toonarmycaptain
changed the title
|
Retry DeepCode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tempdir feature added.Pathpassing enforcement.create_class,new_chart)Classobject tocreate_chart.