Fix creating modnotes with no label #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting the prop to `undefined` causes it to just not be set. `value` being missing causes the text of the option to be used as the value, and reddit will reject the text "(no label)" as a label type because it expects us to send nothing for no label
14 tasks
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
valueprop of an<option>toundefinedcauses it to just not be set.valuebeing missing causes the text of the option to be used as the value, and reddit will reject the text "(no label)" as a label type because it expects us to send nothing for no label. setting the prop to an empty string causes an empty string to be used as the form value, which is correctly translated to nothing being sent