Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments: Await modbar before adding removed comment hider #872

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Nov 23, 2023

Issue reported on Discord - race condition where the comments module would try to add the hider button to the modbar prior to the modbar existing, which would fail. Related to #617

@eritbh eritbh added bug something isn't working module: comment labels Nov 23, 2023
@eritbh eritbh added this to the v6.2.0 milestone Nov 23, 2023
@eritbh eritbh merged commit bb371a5 into master Dec 24, 2023
3 checks passed
@eritbh eritbh deleted the fix/removed-comments-wait-for-modbar branch December 24, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working module: comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant