Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add max retry logic to mod sub retrieval #594

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Re-add max retry logic to mod sub retrieval #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension/data/tbcore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ export const getApiThingInfo = (id, subreddit, modCheck) => new Promise(resolve
* @param {string} [after] Pagination parameter used for recursion
* @returns {Promise<object[]>}
*/
async function fetchModSubs (after) {
async function fetchModSubs (after, tries = 1) {
let json;
try {
json = await TBApi.getJSON('/subreddits/mine/moderator.json', {
Expand All @@ -1238,9 +1238,9 @@ async function fetchModSubs (after) {
});
TBStorage.purifyObject(json);
} catch (error) {
if (error.response && error.response.status === 504) {
// Always retry 504s
return fetchModSubs(after);
// Retry 504s, up to 5 attempts; otherwise throw the error
if (error.response && error.response.status === 504 && tries < 5) {
return fetchModSubs(after, tries + 1);
} else {
throw error;
}
Expand Down