Modnotes support #566
Modnotes support #566
Conversation
erin you literally wrote this API why are you still using `self`
|
Had some quick looks arround and the basis looks good. A few things I noticed (you probably also know or saw):
|
|
"NN" has just been there since before we talked about what to make it, can change later. Yeah, handling notes for users that don't already have any (and also proper handling and display of errors) is TODO. The only bit of info I don't integrate yet is the thing IDs, everything else should be accounted for. I've put off dealing with thing IDs because I want to be able to link to them, but we can get comment IDs without any information about their post ID which makes it impossible to link to the comment without first making an API requests to find out its post ID, then building the Caching is a giant TODO at the moment, yes. I put a comment in there somewhere about using the batch API but haven't had a chance to look at it just yet. That will probably be the next thing I work on after implementing note label selection when creating new notes. |
Nah that works for me, it is just when opening the popup. To not delay building of the popup we could explore doing this as an async call where we first build the popup and leave out links where we don't have enough information. Then fire of the api calls to fetch that information and update those entries in the popup once the call is finished. We could possibly keep a cache of that as well if we want to. |
We can't get them from the bulk API so we're just not gonna show them
* Add TBApi function for fetching mod notes * Add subreddit IDs to oldreddit jsAPI shim events * Add TBApi helper for fetching subreddit info * Basic new modnotes module * that's not how you jQuery... * properly provide user/author IDs to shim events * Rework for new fullname-less notes API * Remove ID handling from old reddit jsAPI shim * Display latest mod note in badge * Fetch more notes at once * Allow fetching more notes for pagination later * Add doc comment to TBApi.getModNotes * Add coloring, note count indicator * Pass less to badge functions; cleanup * Doc comment updates * Basic popup code * fix rebase issue * more rebase fixing * fix dumb logging errors erin you literally wrote this API why are you still using `self` * basics of notes table * comment/doc updates * big scary HTML strings to make it look nice * make more text human-friendly * Add some basic styles * remove unneeded debug output * restructure note table stuff into its own function * hey look now we can create notes * wow look at that now you can delete things too * get my todos in order * thank you eslint i am dumb * Add TBApi method for bulk fetching recent notes * Add + use helper for getting latest notes in bulk * Remove note counts from updateModNotesBadge We can't get them from the bulk API so we're just not gonna show them * Remove resolved TODO * set beta flag because we're merging this soon
Fixes #565