Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by usernote tag #546

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

dequeues
Copy link
Contributor

Implement #534

There is now a dropdown on the usernote search page of all the user note titles, and "All" which you can filter the usertags with.
First PR here, please be kind. 👋

@eritbh eritbh added enhancement New feature or request module: usernotes labels Dec 11, 2021
@eritbh eritbh self-requested a review December 11, 2021 19:47
@eritbh eritbh linked an issue Dec 11, 2021 that may be closed by this pull request
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks so much for taking the time to write a PR for this! I just have a couple suggestions before we can merge it.

extension/data/modules/usernotes.js Outdated Show resolved Hide resolved
extension/data/modules/usernotes.js Outdated Show resolved Hide resolved
@dequeues
Copy link
Contributor Author

Agree with both - I'll update the PR soon. Thanks.

@eritbh eritbh added this to the v5.7 milestone Dec 15, 2021
@eritbh
Copy link
Member

eritbh commented Dec 15, 2021

Thanks again for the contribution! This should land in our next feature update.

@eritbh eritbh merged commit 43f00ea into toolbox-team:master Dec 15, 2021
@eritbh eritbh modified the milestones: v5.7, v5.6.5 Apr 11, 2022
eritbh pushed a commit that referenced this pull request Sep 5, 2024
* Filter by usernote tag

* Update with recommendations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module: usernotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usernotes: ability to search the note type as well
2 participants