Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to select by score in queues #214

Merged
merged 4 commits into from
Feb 10, 2020
Merged

Add ability to select by score in queues #214

merged 4 commits into from
Feb 10, 2020

Conversation

Blank-Cheque
Copy link
Contributor

Added ability to select queue items by score greater than or less than a certain number to queuetools.js.

@Blank-Cheque
add select by score
5c5b935 
added ability to select by score greater than or less than x
eritbh
eritbh requested changes Feb 10, 2020
View reviewed changes
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning a function to selector is a clever way to do this, though I wonder if the function could be simplified a bit... Either way, I did notice one bigger issue.

extension/data/modules/queuetools.js Show resolved Hide resolved
eritbh
eritbh requested changes Feb 10, 2020
View reviewed changes
Copy link
Member

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! Just have another suggestion to simplify the selector functions a bit, you can just go ahead and hit "Commit suggestion" on these to make the changes automatically.

extension/data/modules/queuetools.js Outdated Show resolved Hide resolved
extension/data/modules/queuetools.js Outdated Show resolved Hide resolved
Blank-Cheque and others added 2 commits February 9, 2020 21:38
@Blank-Cheque @eritbh
Accept suggestion to fix selectors
8863391 
Co-Authored-By: George <georgej1088@gmail.com>
@Blank-Cheque @eritbh
Accept suggestion to fix selectors
0721ac8 
Co-Authored-By: George <georgej1088@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eritbh
Copy link
Member

eritbh commented Feb 10, 2020

Looks good, all working on my end and no lint errors! Thanks for the contribution.

@eritbh eritbh changed the title Add ability to select by score Add ability to select by score in queues Feb 10, 2020
@eritbh eritbh merged commit cc6e6a5 into toolbox-team:master Feb 10, 2020
@eritbh eritbh added this to the v5.3 milestone Mar 10, 2020
eritbh added a commit that referenced this pull request Sep 5, 2024
@Blank-Cheque @eritbh
Add ability to select by score in queues (#214)
18ca32e 
* add select by score

added ability to select by score greater than or less than x

* Update queuetools.js

* Accept suggestion to fix selectors

Co-Authored-By: George <georgej1088@gmail.com>

* Accept suggestion to fix selectors

Co-Authored-By: George <georgej1088@gmail.com>

Co-authored-by: George <georgej1088@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eritbh eritbh eritbh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Blank-Cheque @eritbh