Prevent modbutton popup in flatview from closing flatview #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creesch
reviewed
Oct 20, 2019
|
|
||
| // 'cancel' button clicked | ||
| $popup.on('click', '.close', () => { | ||
| $popup.remove(); |
There was a problem hiding this comment.
In jQuery remove() also cleans up all references so setting it to null isn't really needed afaik.
There was a problem hiding this comment.
I removed it, a single occurrence in a low-use area shouldn't make a big difference either way.
eritbh
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Prevent modbutton popup in flatview from closing flatview * let to const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168.