Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BetterButtons): added post sticky position #148

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

Venefilyn
Copy link
Member

@Venefilyn Venefilyn commented Oct 4, 2019

fixes #69

This adds positional sticky ability, process looks like pictures below. 1 indicates top position, 2 indicates bottom. I think best would be to change this to top / bottom instead of 1 and 2. Thoughts?

Unsticky has been tested to work as intended with the changes

image

image

image

@creesch
Copy link
Member

creesch commented Oct 4, 2019

top / bottom instead of 1 and 2

Yup sound good. Or possibly just do 1. top / 2. bottom

@Venefilyn
Copy link
Member Author

Alright, I left it to top / bottom. The numbers don't mean anything to users anyway :P

@creesch creesch merged commit be307a2 into toolbox-team:master Oct 4, 2019
@Venefilyn Venefilyn deleted the feat/sticky-spot branch October 4, 2019 11:30
eritbh pushed a commit that referenced this pull request Sep 5, 2024
feat(BetterButtons): added post sticky position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Betterbuttons "sticky" button on listing pages
2 participants