Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore the possibility of integrating new modmail in the jsapi flow #38

Closed
creesch opened this issue Feb 4, 2019 · 1 comment
Closed
Milestone

Comments

@creesch
Copy link
Member

creesch commented Feb 4, 2019

Currently new modmail is the odd one out that basically does a bit of a hybrid thing between old reddit and new reddit. We probably want to integrate it more into the new reddit jsAPI event flow so relevant buttons are easier to implement in new modmail as well.

Prompted today with me wanting to use the toolbox profile feature in modmail and finding out that we don't have any way to trigger it there. Which is very silly of course.

@eritbh
Copy link
Member

eritbh commented Feb 9, 2020

I think we can handle this similarly to how we handle the hover card on the redesign. Ideally, we should set up our event faking system to treat the sidebar area as a fake jsapi region, with the same info sent as for the redesign hover card, so that anything added to one is automatically added to the other. We can do the same for the next-to-name stuff, too, and if we handle #110 as well, then I think that'll cover pretty much all the bases for new modmail.

@eritbh eritbh modified the milestone: v5.3 Mar 10, 2020
eritbh pushed a commit that referenced this issue Sep 5, 2024
* jsAPI flow for sidebar, initial button conversion

* Convert remaining things to jsapi in newmodmail

* remove the need for tbnewthings in newmm

* tab height new modmail ...

* Update extension/data/modules/oldreddit.js

Co-Authored-By: George <georgej1088@gmail.com>

* remove unneeded css property

* remove legacy error handling

* Nothing to see here! (literally)

Co-authored-by: George
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants