Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message for Joined lobby when room is full #332

Open
mmbatha opened this issue Feb 23, 2025 · 1 comment
Open

Message for Joined lobby when room is full #332

mmbatha opened this issue Feb 23, 2025 · 1 comment
Assignees
@toobeeh
Labels
enhancement New feature or request

Comments

@mmbatha
Copy link

mmbatha commented Feb 23, 2025 •
edited
Loading

As a logged-in Palantir user, when attempting to join another user in their lobby and the room is full, the notification reads Joined the lobby of [another user]. Shortly after, the message room is full appears.

Image

My suggestion is an improvement of the notification to read Joining the lobby... or Trying to join [another user]'s lobby
@mmbatha mmbatha added the enhancement New feature or request label Feb 23, 2025
@toobeeh toobeeh moved this to Todo in skribbltypo Feb 23, 2025
toobeeh added a commit that referenced this issue Feb 23, 2025
@toobeeh
add error message when lobby join failed
341cc8f 
#332
@toobeeh toobeeh moved this from Todo to In Review in skribbltypo Feb 23, 2025
toobeeh pushed a commit to toobeeh/skribbltypo-nightly that referenced this issue Feb 23, 2025
add error message when lobby join failed
7172c8e 
toobeeh/skribbltypo#332
original commit: toobeeh/skribbltypo@341cc8f
toobeeh added a commit that referenced this issue Feb 23, 2025
@toobeeh
improve lobby join failure event name
078b9e2 
#332
@mmbatha
Copy link
Author

mmbatha commented Feb 25, 2025

Unable to replicate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toobeeh toobeeh

Labels
enhancement New feature or request
Projects
skribbltypo
Status: In Review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmbatha @toobeeh