This repository has been archived by the owner on Jul 9, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails Initializers
The following ruby outputs the grepped initializers in the order that they are tsorted in:
It's run below using Rails runner:
Expected Behavior
When adding
newrelic_rpm
with a config and a method tracer to a new Rails project (b1f6196), the initializers run as expected.NewRelic's initializer,
newrelic_rpm.start_plugin
, runs before Rails loads the initialization files.Reproduced Error
When adding another gem that inserts an initializer that is configured to run after
load_config_initializers
(such asheroku_rails_deflate
) NewRelic's initializer is sorted afterload_config_initializers
.Now,
newrelic_rpm.start_plugin
now runs afterload_config_initializers
, which causes an error since the NewRelic agent has not been initialized when the method tracer is defined.Fix
When
newrelic_rpm
is patched, specifying the plugin to be initialized beforeload_config_intializers
(d2bca68), the problem is fixed.The plugin is correctly loaded before
load_config_initializers
and no warning is displayed.