Refactored Reachability with a three-letter prefix #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would break its "drop in" replacement for the older Apple stuff. I'll leave this open though so others could use your patch. |
|
I don't have an interest in seeing this added myself but I think I've seen this requested before so maybe 318386e would be a useful addition. |
|
Hello, if your readme states that apps will get rejected with the current name, then drop in feature has to be dropped. I suggest TMReachability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the Reachability class to have a three-letter prefix as per Apple's recommendations. http://developer.apple.com/library/ios/#documentation/cocoa/conceptual/ProgrammingWithObjectiveC/Conventions/Conventions.html
Great work on this class, thanks for providing it!
best,
Michael Fey
michael@nothirst.com
No Thirst Software LLC