Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to loop-invariant-global-usage #30

Merged
merged 2 commits into from
May 15, 2022
Merged

Update references to loop-invariant-global-usage #30

merged 2 commits into from
May 15, 2022

Conversation

pR0Ps
Copy link
Contributor

@pR0Ps pR0Ps commented May 13, 2022

Looks like these were missed as part of #27

Was seeing the following error while re-testing #26 at 4bf47e0

$ perflint repro.py
Exception on node <Name.x l.5 at 0x10efcae90> in file '/tmp/repro.py'
Traceback (most recent call last):
  File "/tmp/venv-710/lib/python3.10/site-packages/pylint/utils/ast_walker.py", line 73, in walk
    callback(astroid)
  File "/tmp/venv-710/lib/python3.10/site-packages/perflint/for_loop_checker.py", line 324, in visit_name
    self.add_message("loop-invariant-global-usage", node=node)
  File "/tmp/venv-710/lib/python3.10/site-packages/pylint/checkers/base_checker.py", line 112, in add_message
    self.linter.add_message(
  File "/tmp/venv-710/lib/python3.10/site-packages/pylint/lint/pylinter.py", line 1629, in add_message
    message_definitions = self.msgs_store.get_message_definitions(msgid)
  File "/tmp/venv-710/lib/python3.10/site-packages/pylint/message/message_definition_store.py", line 65, in get_message_definitions
    for m in self.message_id_store.get_active_msgids(msgid_or_symbol)
  File "/tmp/venv-710/lib/python3.10/site-packages/pylint/message/message_id_store.py", line 130, in get_active_msgids
    raise UnknownMessageError(error_msg)
pylint.exceptions.UnknownMessageError: No such message id or symbol 'loop-invariant-global-usage'.

Looks like these were missed as part of #27
@tonybaloney
Copy link
Owner

Ouch. Nice spot. thanks

@tonybaloney tonybaloney merged commit 9e246da into tonybaloney:main May 15, 2022
@pR0Ps pR0Ps deleted the patch-1 branch May 16, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants