Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hostnames in endpoints #56

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Allow hostnames in endpoints #56

merged 5 commits into from
Apr 20, 2021

Conversation

mcginty
Copy link
Collaborator

@mcginty mcginty commented Apr 20, 2021

This draft creates an Endpoint type that wraps url::Host to avoid correctness issues with hostname parsing.

Resolution uses the ToSocketAddrs trait in std, and only uses the first result.

Fixes #18

@mcginty mcginty mentioned this pull request Apr 20, 2021
Closed
@mcginty mcginty marked this pull request as ready for review April 20, 2021 14:27
@mcginty mcginty merged commit 0a26bde into main Apr 20, 2021
@mcginty mcginty deleted the dns-endpoints branch April 20, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow domain for external endpoint
1 participant
@mcginty