Fix: Missing CSS when do_blocks is ran early #683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #682
#682 works but has an issue where CSS (singular and block-specific) is duplicated when using block themes.
This method works by using
wp_enqueue_scripts
andwp_add_inline_style
for our inline style. This works becausewp_enqueue_scripts
fires beforewp_head
which is where Slim SEO (in this case) is callingdo_blocks
.We also have to check
$block_ids
within thegenerateblocks_get_dynamic_css
function to prevent duplicate CSS in block themes.Not sure if this is the best solution.