Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak: Improve dynamic CSS generation #607

Merged
merged 15 commits into from
Aug 23, 2022
Merged

Tweak: Improve dynamic CSS generation #607

merged 15 commits into from
Aug 23, 2022

Conversation

tomusborne
Copy link
Owner

close #454

This PR does a few things:

  1. It adds block-specific PHP classes that hold their defaults, CSS and frontend renders.
  2. If one of our blocks has been added to a part of a site that's not in the post_content it should generate the necessary CSS inline using <style> tags above the block HTML.

@tomusborne tomusborne added the feature Features, refactoring, enhancements, improvements label Jun 27, 2022
@tomusborne tomusborne added this to the 1.6.0 milestone Jun 27, 2022
@tomusborne tomusborne requested a review from JeanPaiva August 5, 2022 17:28
JeanPaiva
JeanPaiva approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@JeanPaiva JeanPaiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems everything is working fine.

The widget are requires the commit https://github.com/tomusborne/generateblocks-pro/pull/151/commits/773630f2a3db8db20f538829edf4b33f144527ca in order to work, we can merge after the ACF or cherry-pick the commit.

@tomusborne tomusborne linked an issue Aug 22, 2022 that may be closed by this pull request
Enqueue styles for blocks added in FSE #454
Closed
@tomusborne tomusborne merged commit ea55f81 into release/1.6.0 Aug 23, 2022
@tomusborne tomusborne deleted the better-css-generation branch August 23, 2022 16:56
@JeanPaiva JeanPaiva modified the milestone: 1.7.0 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanPaiva JeanPaiva JeanPaiva approved these changes

Assignees
No one assigned
Labels
feature Features, refactoring, enhancements, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enqueue styles for blocks added in FSE
2 participants
@tomusborne @JeanPaiva