Feature: Add media dynamic tag
#1569
Conversation
| @@ -722,6 +731,25 @@ export function DynamicTagSelect( { onInsert, tagName, selectedText, currentPost | |||
| </> | |||
| ) } | |||
|
|
|||
| { 'media' === dynamicSource && ( | |||
| <> | |||
| <SelectPost | |||
There was a problem hiding this comment.
Any reason we wouldn't want to do an actual Media Library modal here? Seems odd to ask someone to choose an image from a list where they can't see the image, no?
There was a problem hiding this comment.
That would be ideal, but I wanted to get this into the release candidate, and I figured adding a new pattern like a Media Library modal would have some increased overhead.
It would definitely be nice for the user to be able to choose the image. Worth a quick play to see what kind of overhead we're looking at.
There was a problem hiding this comment.
Based on the current change from select post, this may cause incorrect behavior in other places (ex: Query block options).
We just need to make sure the other implementations are updated to use the correct postStatus value. The only 2 places that come to mind are the free/pro Query Inspector Controls.
There was a problem hiding this comment.
@tomusborne Looks like you need to add handling for the media source and include the 'source" supports in your tag registration.
When I first pulled this, the source selection didn't show up at all (because source support isn't declared) but even then you're going to need some logic to make the labels make sense and such.
Requires https://github.com/EDGE22-Studios/components/pull/13
This allows us to use a
{{media}}dynamic tag to pull in items from the Media Library.This can be used to dynamic fetch images, or their captions/alt tags etc...