Better test assertion. (apache#17551)

tomstepp · May 12, 2022 · dc20185 · dc20185
1 parent 5bb50d1
commit dc20185
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/sdks/python/apache_beam/io/gcp/bigquery_json_it_test.py b/sdks/python/apache_beam/io/gcp/bigquery_json_it_test.py
@@ -100,13 +100,13 @@ def process(self, row):
         # Test country (JSON String)
         country_actual = json.loads(row["country"])
         country_expected = json.loads(expected["country"])
-        self.assertTrue(country_expected == country_actual)
+        self.assertEqual(country_expected, country_actual)
 
         # Test stats (JSON String in BigQuery struct)
         for stat, value in row["stats"].items():
           stats_actual = json.loads(value)
           stats_expected = json.loads(expected["stats"][stat])
-          self.assertTrue(stats_expected == stats_actual)
+          self.assertEqual(stats_expected, stats_actual)
 
         # Test cities (JSON String in BigQuery array of structs)
         for city_row in row["cities"]:
@@ -115,15 +115,15 @@ def process(self, row):
 
           city_actual = json.loads(city)
           city_expected = json.loads(expected["cities"][city_name])
-          self.assertTrue(city_expected == city_actual)
+          self.assertEqual(city_expected, city_actual)
 
         # Test landmarks (JSON String in BigQuery array)
         landmarks_actual = row["landmarks"]
         landmarks_expected = expected["landmarks"]
         for i in range(len(landmarks_actual)):
           l_actual = json.loads(landmarks_actual[i])
           l_expected = json.loads(landmarks_expected[i])
-          self.assertTrue(l_expected == l_actual)
+          self.assertEqual(l_expected, l_actual)
 
     parser = argparse.ArgumentParser()
     parser.add_argument('--read_method')