feat(de): Track spans in errors #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally didn't do this as there isn't really anything to reference for a table but the keys and I didn't think it'd be too helpful for a `toml_edit::Table` API. However, I'd like to have spans for every serde error, so here we are.
In theory, everything boilds down to being a key or an item, so we only need to explicitly add missing spans in those cases. We'll see what reports we get from users on this.
The downside to this is we do not always have enough information to print the span and we lost the ability to instead say the key. I'm assuming that is minor enough of a case to not be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caller can ask for the span and we report it in the error messages. This does come with a regression when an error does not originate from a toml string.
This had no discernible performance impact.
Fixes #303