Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MD027 violation on sql-server.md #892

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

adamconnelly
Copy link
Contributor

markdownlint was complaining because there was a blockquote defined without an angle bracket on each line. This triggered https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md027---multiple-spaces-after-blockquote-symbol.

I think what's happened is that the docs folder wasn't configured to trigger an Azure Pipelines build, so the check was never run on the PR. I've updated the pipelines file to trigger a build on changes to the docs folder now.

@tomkerkhove do you think it makes sense to have a separate pipeline for the docs folder so it doesn't need to run a full build of the code if you're just making a documentation change? I went with the easy option of just adding the docs folder for now, but I figured it was worth asking.

markdownlint was complaining because there was a blockquote defined without an angle bracket on each line. This triggered <https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md027---multiple-spaces-after-blockquote-symbol>.

I think what's happened is that the docs folder wasn't configured to trigger an Azure Pipelines build, so the check was never run on the PR. I've updated the pipelines file to trigger a build on changes to the docs folder now.
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkerkhove
Copy link
Owner

Good point, I'll open an issue for it!

@tomkerkhove tomkerkhove self-assigned this Feb 22, 2020
@tomkerkhove tomkerkhove merged commit 804e699 into tomkerkhove:master Feb 22, 2020
@adamconnelly adamconnelly deleted the fix-sql-server-docs branch June 16, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants