-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better usage of AzureMonitorClient
#844
Conversation
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr844 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr844 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
--volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr844 You can find a CI version of our Helm chart on hub.helm.sh |
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr844 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr844 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
--volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr844 You can find a CI version of our Helm chart on hub.helm.sh |
@maartenba Did a bit of refactoring but didn't seem to really help. However, it looks like there's a shitload of |
It shows unique ones, yes. Can you send me a longer run snapshot? Will have a look at it. |
Performance analysis before & after can be downloaded from DropBox |
Checking "after". Looks like lots of leftover That in turn seems to not be disposed by The AzMon libraries seem to hold a lot of these references as well, but can't really pinpoint where those come from. Would you mind running performance profiling in Timeline mode as well? That should give some more info on # calls etc. |
You can download it here @maartenba |
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr844 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr844 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
--volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr844 You can find a CI version of our Helm chart on hub.helm.sh |
OK, ran through all traces, and found Example instance: All instances: Looks like there is a way to pass in an existing |
@maartenba Think it's safe to merge this or think it is not? The issue lies in the SDK so can't do much about it, but this PR still improves it a bit. Thougths? |
Think it's safe to do so, however if you figure out a way to pass in an existing |
Provide better usage of
AzureMonitorClient
by only creating it once.Relates to #798
Before
After