Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Helm Chart improvements #696

Merged
merged 4 commits into from
Sep 2, 2019
Merged

General Helm Chart improvements #696

merged 4 commits into from
Sep 2, 2019

Conversation

tomkerkhove
Copy link
Owner

General Helm Chart improvements:

  • Remove secret from file for Helm deployment guidance
  • Remove runtime prefix for variables
  • Update sample in values.yaml to new metric format
  • Align walkthrough with new metric format

Fixes #658

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr696

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr696 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr696

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove merged commit 949fb4a into master Sep 2, 2019
@tomkerkhove tomkerkhove deleted the improve-chart branch September 2, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Deploying Promitor, Prometheus, and Grafana on an AKS Cluster" walkthrough for v1.0
2 participants