Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource group overriding #656

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix resource group overriding #656

merged 1 commit into from
Aug 13, 2019

Commits on Aug 13, 2019

  1. Fix resource group overriding 

    The ability to override the resource group per metric was broken for all resource types other than the Generic resource type.

This commit:

- Fixes the tests for all resource types to test for this by removing the `Ignore()` method calls for the `ResourceGroupName` property and added an extra assert to check for the resource group.
- Alters the deserializers to inherit directly from `MetricDeserializer` rather than `GenericAzureMetricDeserializer`. They weren't actually using any of the functionality from the generic type.
- Fixes a few Scraper implementations to actually use the overridden group name.

Fixes tomkerkhove#655
    @adamconnelly
    adamconnelly committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    222e5a6 View commit details
    Browse the repository at this point in the history