Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for Metric Scraping interval to be defined overall & per-metric via YAML config #473

Merged
merged 30 commits into from
Mar 29, 2019
Merged

Allow for Metric Scraping interval to be defined overall & per-metric via YAML config #473

merged 30 commits into from
Mar 29, 2019

Commits on Mar 28, 2019

  1. Scraping Interval is not nullable on the metricDefaults in config any… 

    …more
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    e09f68b View commit details
    Browse the repository at this point in the history

  2. Utilize the MetricsDeclarationProvider to apply defaults to metrics; … 

    …don't push this logic down in to the scrapers
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    796bda2 View commit details
    Browse the repository at this point in the history

  3. rename UseCronScheduler to ScheduleMetricScraping

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    80e10c5 View commit details
    Browse the repository at this point in the history

  4. Allow MetricScrapingJob to take the Metric to scrape; enables jobs ta… 

    …rgeting different metrics to be scheduled
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    6890bdf View commit details
    Browse the repository at this point in the history

  5. reworking scraping.interval -> scraping.schedule (string) to be used … 

    …as a cron expression instead of System.Timespan
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    6fd7aab View commit details
    Browse the repository at this point in the history

  6. adding scraper.schedule to metric builder used by UTs

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ec92ce6 View commit details
    Browse the repository at this point in the history

  7. moving scheduling from env var -> YAML config

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    d3a5c74 View commit details
    Browse the repository at this point in the history

  8. add metric scraping schedule validation

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    2537e41 View commit details
    Browse the repository at this point in the history

  9. IEnumerable<T> + yield return refactor for Validators

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    817fdaa View commit details
    Browse the repository at this point in the history

  10. when validating and returning metric detail, apply defaults from metr… 

    …icDefaults to metrics that don't have values for those properties
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    b134fa0 View commit details
    Browse the repository at this point in the history

  11. add default scraping schedule + different scraping schedule for some … 

    …metrics to illustrate cusomizability and new usage of metricDefaults for overall scraping schedule (vs old env variable)
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    fa51f13 View commit details
    Browse the repository at this point in the history

  12. Utilize the MetricsDeclarationProvider to apply defaults to metrics; … 

    …don't push this logic down in to the scrapers
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    11e121c View commit details
    Browse the repository at this point in the history

  13. reworking scraping.interval -> scraping.schedule (string) to be used … 

    …as a cron expression instead of System.Timespan
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    032c1bd View commit details
    Browse the repository at this point in the history

  14. adding scraper.schedule to metric builder used by UTs

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f4c6f12 View commit details
    Browse the repository at this point in the history

  15. add default scraping schedule + different scraping schedule for some … 

    …metrics to illustrate cusomizability and new usage of metricDefaults for overall scraping schedule (vs old env variable)
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ec19652 View commit details
    Browse the repository at this point in the history

  16. temp: working on UTs

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    0f33df7 View commit details
    Browse the repository at this point in the history

  17. fixing declaration provider's default assigning

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    7616c5c View commit details
    Browse the repository at this point in the history

  18. deserializing scraping default w/ its own deserializer

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c6b4240 View commit details
    Browse the repository at this point in the history

  19. adding validation to scraping default YAML item

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    a6ea912 View commit details
    Browse the repository at this point in the history

  20. adding scraping default value to default instance of declaration buil… 

    …der for UTs
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    7179f49 View commit details
    Browse the repository at this point in the history

  21. conforming Richard's changes to the new metricDefaults architecture

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    4695566 View commit details
    Browse the repository at this point in the history

  22. codeFactor fix

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    e027b81 View commit details
    Browse the repository at this point in the history

  23. fixing resharper warnings

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    3d25c55 View commit details
    Browse the repository at this point in the history

  24. supporting docs for metric scraping interval change

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ca0c378 View commit details
    Browse the repository at this point in the history

  25. move metric resourceGroupName -> new optional area of metric definiti… 

    …on docs
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    a436d66 View commit details
    Browse the repository at this point in the history

  26. this catch no longer needed due to internal refactoring of deserializ… 

    …ation & validation
    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    b91f750 View commit details
    Browse the repository at this point in the history

  27. remove redundant setting of metricDefaults in UT declaration builder

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f5e6de2 View commit details
    Browse the repository at this point in the history

  28. whoops

    @brandonh-msft
    brandonh-msft committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ef0d231 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Merge branch 'master' into brandonh/feature/metric-scraping-interval-… 

    …impl
    @tomkerkhove
    tomkerkhove authored Mar 29, 2019
    Configuration menu
    Copy the full SHA
    a1acbb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into brandonh/feature/metric-scraping-interval-… 

    …impl
    @brusMX
    brusMX authored Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2019670 View commit details
    Browse the repository at this point in the history